-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VSS client #645
VSS client #645
Conversation
12602e9
to
3273af3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clean and straitforward. Just a nit about not using anyhow
otherwise LGTM.
ce04bb9
to
230261c
Compare
b0e8048
to
f370ffc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor things but this looks as elegant as you could make it, at least for now. Very nice work, looking forward to testing this out!
Wait where is the channel manager being saved? Only saw some call outs for monitor. |
Didn't do that because it didn't have an easy version number. We'll have to implement our own versioning with it. |
I think we'll have to do this though in order for this remote cloud feature to be useful. Do you think that's attainable as part of this PR? |
done |
No description provided.